Skip to content

[WD-13340] set owner and reviewers on each webpage #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2024
Merged

[WD-13340] set owner and reviewers on each webpage #53

merged 3 commits into from
Sep 11, 2024

Conversation

@akbarkz
Copy link
Contributor

@akbarkz akbarkz commented Sep 6, 2024

Done

  • Added two new fields to the Webpage view: Owner and Reviewers.

QA

  • Run the project locally via dotrun
  • Open 0.0.0.0:8104 in the browser
  • Turn on VPN in order to make directory-api work
  • Open any webpage's view
  • Try setting an Owner field by typing someone's name into the field
    • Check that only one owner can be specified
    • Navigate to other pages and return to the previous page to make sure the owner is still set
  • Try setting Reviewers by doing the same as with the Owner field
    • Check that you can several several people
    • Check that the same person cannot be selected twice
    • Navigate to other pages and return to the previous page to make sure reviewers are still set
  • Refresh the page and check if values of the Owner and Reviewers are still the same

Fixes

Screenshots

Screenshot 2024-09-06 at 20 18 06

@akbarkz akbarkz force-pushed the task/WD-13340-set_owner_ui branch from 167daed to 8425d3a Compare September 6, 2024 15:44
@immortalcodes
Copy link
Member

Some Comments

  • Is there an option to unset owner as well?
  • Can we remove a reviewer as well?
  • We should display a success message since sometimes the API call could take time and closing that window might not complete api call
  • If I search something and go to another page the search keyword and the results are carried to the new page.
  • The suggestion window interrupts with search results.

@akbarkz
Copy link
Contributor Author

akbarkz commented Sep 11, 2024 •
edited
Loading

Is there an option to unset owner as well?
Can we remove a reviewer as well?

This is fixed

We should display a success message since sometimes the API call could take time and closing that window might not complete api call

I don't think we need that, cause setting and removing is quite quick

If I search something and go to another page the search keyword and the results are carried to the new page.

Fixed that.

The suggestion window interrupts with search results.

Removed the suggestion window

@akbarkz akbarkz merged commit 73a54f6 into main Sep 11, 2024
7 checks passed
@akbarkz akbarkz deleted the task/WD-13340-set_owner_ui branch September 11, 2024 08:22
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@immortalcodes immortalcodes immortalcodes approved these changes

Assignees

No one assigned

Labels

released Review: Code +1 Review: QA +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akbarkz @immortalcodes